Skip to content

[5.5] Show exception class in JSON #21043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2017
Merged

[5.5] Show exception class in JSON #21043

merged 1 commit into from
Sep 6, 2017

Conversation

@themsaid
Copy link
Member

@themsaid themsaid commented Sep 6, 2017

Some exceptions don't have a verbose message, for that reason it might be nice to include the exception class to help developers understand what went wrong.

{
  "message": "name",
  "exception": "Illuminate\\Database\\Eloquent\\MassAssignmentException",
  "file": "/Users/mac/sites/laravel-src/laravelcurrent/src/Illuminate/Database/Eloquent/Model.php",
  "line": 237,
  "trace": [
    {
      "file": "/Users/mac/sites/laravel-src/laravelcurrent/src/Illuminate/Database/Eloquent/Model.php",
      "line": 157,
    }
  ]
}

Examples of these exceptions:

  • MassAssignmentException
  • LimiterTimeoutException
  • PostTooLargeException
  • LockTimeoutException

@themsaid themsaid mentioned this pull request Sep 6, 2017
Closed
@taylorotwell taylorotwell merged commit eb4b5a6 into laravel:5.5 Sep 6, 2017
gonzahce added a commit to gonzahce/framework that referenced this pull request Sep 6, 2017
@gonzahce
Updating from base repo (#4)
6b99b8b 
*      catch errors as well (laravel#21047)

* return  from Validator::setCustomMessages (laravel#21046)

*       show exception class in JSON (laravel#21043)

* [5.5] Removed listener listensFor (laravel#21039)

* remove listensFor

* remove listensFor

* Specify lower case `column_name` (fixes laravel#20190) (laravel#21037)

* [5.5] Add policies method to Gate (laravel#21036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@themsaid @taylorotwell