Skip to content

[5.5] DelegatesToResource: fix offsetExists. #20887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2017
Merged

[5.5] DelegatesToResource: fix offsetExists. #20887

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2926b71
Fix offsetExists.
lucasmichot Aug 31, 2017
c907481
Switch argumebts
lucasmichot Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Http/Resources/DelegatesToResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function resolveRouteBinding($value)
*/
public function offsetExists($offset)
{
return array_key_exists($this->resource[$offset]);
return array_key_exists($this->resource, $offset);
Copy link
Member

@themsaid themsaid Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I believe you mean:

return array_key_exists($offset, $this->resource);

Copy link
Contributor Author

@lucasmichot lucasmichot Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed: c907481

Copy link
Contributor

@laurencei laurencei Aug 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all seriousness - why did the tests not catch that error?

}

/**
Expand Down