Update FilesystemAdapter.php #20398
Merged
Update FilesystemAdapter.php #20398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation does not allow other adapters a chance to implement a `temporaryUrl()` as the `$adapter->getClient()` gets called in first which is not how it works in all cases (in openstack for eg, there is no `getClient()` on the adapter). This PR allows for this to be possible.
Member
|
Why are you not passing the rest of the arguments? Doesn't make sense. |
Contributor
Author
|
@taylorotwell My bad. I was using defaults in my adapter for the other arguments and forgot to include parameters to this call. PR is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not allow other adapters a chance to implement a
temporaryUrl()as the$adapter->getClient()gets called in first which is not how it works in all cases (in openstack for eg, there is nogetClient()on the adapter).This PR allows for this to be possible.