[5.4] update timestamp on soft delete only when its used #19627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieutu
added a commit
to mathieutu/framework
that referenced
this pull request
Jun 19, 2017
* commit '05060b183dd09cee6dce498da5afde9e66fd1a29': Apply fixes from StyleCI (laravel#19659) [5.4] Add ability to remove a global scope with another global scope (laravel#19657) [5.4] Add fresh method on Eloquent\Collection. (laravel#19616) support multiple fields to validateDifferent (laravel#19637) escape default value of yield blade directive (laravel#19643) [5.4] Add "avg" and "average" to higher order proxy. (laravel#19628) tagged v5.4.27 release notes version Add missing dependency. (laravel#19623) update timestamp on soft delete only when its used (laravel#19627) Add new `diffAssoc()` method to collection (laravel#19604) Fix tests code coverage config. (laravel#19609) # Conflicts: # src/Illuminate/Database/Eloquent/Collection.php
Contributor
|
Hello Mohamed, Thank you for the fix. I would like to point out that it will still break for people having the following kind of models: class Example extends Model
{
public $timestamps = true;
const CREATED_AT = 'created_at';
const UPDATED_AT = null; // Disable `updated_at` field
}I'm pretty sure this use case is not recommended and then it will probably be a wont-fix, but I just wanted to make sure you are aware of it. Thanks! |
Contributor
|
@kamui545 If you don't want the |
Contributor
|
@bobbybouwmann This is exactly the use case I am explaining, having no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported in #19620, the breaking change was introduced in #19538
This PR doesn't revert, but only updates the
updated_atcolumn if the Model's timestamps = true.