[5.4] Fixes phpdocs on abstract ServiceProvider class #18248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the interface/contract Application is specified on the following code:
Problem:: There are service providers that assume that the
$appimplementation have the methodrunningInConsole. For example the MailServiceProvider on the method:Since runningInConsole do not exist on the contract, I propose is just specify on the php docs that service providers are instantiated with instance of Illuminate\Foundation\Application.