[5.3] Fix lower case model names in policy classes#15270
Merged
Conversation
Fixes the model name variables (from lower case to camel case) when generating a policy class based on a model.
Member
|
Please give an example of what this fixes. |
Contributor
Author
|
If a policy class is generated based on a model, the parameters of that class methods are lower case.
class ProductCategoryPolicy
{
// before fix
/**
* Determine whether the user can view the productcategory.
*
* @param App\User $user
* @param App\ProductCategory $productcategory
* @return mixed
*/
public function view(User $user, ProductCategory $productcategory)
{
//
}
// after fix
// "productcategory" --> "productCategory"
/**
* Determine whether the user can view the productCategory.
*
* @param App\User $user
* @param App\ProductCategory $productCategory
* @return mixed
*/
public function view(User $user, ProductCategory $productCategory)
{
//
}
} |
tillkruss
pushed a commit
to tillkruss/framework
that referenced
this pull request
Sep 8, 2016
Fixes the model name variables (from lower case to camel case) when generating a policy class based on a model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the model name variables (from lower case to camel case) when generating a policy class based on a model.