[5.3] Add greeting option to SimpleMessage notification#15108
Merged
Conversation
By default 'Hello!' or 'Whoops!' is displayed as greeting.
You can override this with the `greeting()` method:
```
public function toMail($notifiable)
{
return (new MailMessage)
->greeting("Hi {$notifiable->name},")
->line('The introduction to the notification.')
->action('Notification Action', 'https://laravel.com')
->line('Thank you for using our application!');
}
```
| public $subject; | ||
|
|
||
| /** | ||
| * Greeting at the beginning of the notification. |
Contributor
Author
There was a problem hiding this comment.
@GrahamCampbell I don't know what you mean, I added a new line, styleci is failing now
Member
|
I don't like nested ternarys. Can you get rid of that? |
Contributor
Author
|
@taylorotwell I replaced it with if-else : 0e193ea |
Contributor
|
@balping: This broke the plain text email. |
Contributor
Author
|
How so? Is there a syntax error or something? |
Contributor
|
There are no new lines after the greeting. I'll submit a PR to fix that. |
Contributor
Author
|
Ok, thanks and sorry about this |
Contributor
|
No worries, I love the greeting. Much more flexibility! |
This was referenced Jan 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default 'Hello!' or 'Whoops!' is displayed as greeting.
You can override this with the
greeting()method: