Skip to content

refactor(web): migrate tag controls to combobox#35881

Merged
lyzno1 merged 11 commits intomainfrom
rft/tag-selector
May 7, 2026
Merged

refactor(web): migrate tag controls to combobox#35881
lyzno1 merged 11 commits intomainfrom
rft/tag-selector

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 7, 2026

Summary

  • migrate tag selector and tag filter surfaces to the Dify UI combobox primitives
  • keep tag search input clearing scoped to the query while preserving selected tags
  • improve related focus affordances for app cards and tooltip/focus interactions

Part of #35867

Tests

  • pnpm --dir web test tag-filter.spec.tsx tag-panel.spec.tsx tag-selector.spec.tsx
  • pnpm --dir web test app-card.spec.tsx
  • pnpm --dir web type-check

@lyzno1 lyzno1 requested review from JzoNgKVO, iamjoel and zxhlyh as code owners May 7, 2026 08:33
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. refactor labels May 7, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 7, 2026
@lyzno1 lyzno1 enabled auto-merge May 7, 2026 08:34
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 97.05882% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.82%. Comparing base (8b77ec7) to head (affdb0b).

Files with missing lines Patch % Lines
...eatures/tag-management/components/tag-selector.tsx 94.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35881      +/-   ##
==========================================
- Coverage   85.83%   85.82%   -0.01%     
==========================================
  Files        4462     4463       +1     
  Lines      209146   209159      +13     
  Branches    39125    39116       -9     
==========================================
+ Hits       179512   179520       +8     
- Misses      26458    26463       +5     
  Partials     3176     3176              
Flag Coverage Δ
dify-ui 93.93% <ø> (ø)
web 86.77% <97.05%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hyoban
hyoban previously approved these changes May 7, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 7, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit cd66559 May 7, 2026
33 checks passed
@lyzno1 lyzno1 deleted the rft/tag-selector branch May 7, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants