Skip to content

feat: support key up and down to select variable item#35527

Merged
CodingOnStar merged 4 commits intomainfrom
feat/support-key-up-down-enter-select-var
Apr 24, 2026
Merged

feat: support key up and down to select variable item#35527
CodingOnStar merged 4 commits intomainfrom
feat/support-key-up-down-enter-select-var

Conversation

@iamjoel
Copy link
Copy Markdown
Contributor

@iamjoel iamjoel commented Apr 23, 2026

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 23, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Apr 23, 2026
@dosubot dosubot Bot added the 💪 enhancement New feature or request label Apr 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 91.01124% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.57%. Comparing base (0c8dec3) to head (1b1d7a4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/_base/components/variable/var-reference-vars.tsx 90.47% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35527      +/-   ##
==========================================
- Coverage   85.57%   85.57%   -0.01%     
==========================================
  Files        4440     4440              
  Lines      207777   207845      +68     
  Branches    38824    38841      +17     
==========================================
+ Hits       177806   177861      +55     
- Misses      26850    26863      +13     
  Partials     3121     3121              
Flag Coverage Δ
dify-ui 93.01% <ø> (ø)
web 86.50% <91.01%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hjlarry
hjlarry previously approved these changes Apr 24, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 24, 2026
Copy link
Copy Markdown
Contributor

@CodingOnStar CodingOnStar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodingOnStar CodingOnStar added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 38fc2a6 Apr 24, 2026
33 checks passed
@CodingOnStar CodingOnStar deleted the feat/support-key-up-down-enter-select-var branch April 24, 2026 02:41
asukaminato0721 pushed a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants