Skip to content

test(e2e): add publish app happy path scenario#35503

Merged
Jingyi-Dify merged 3 commits intomainfrom
test/app-publish-happy-path
Apr 23, 2026
Merged

test(e2e): add publish app happy path scenario#35503
Jingyi-Dify merged 3 commits intomainfrom
test/app-publish-happy-path

Conversation

@Jingyi-Dify
Copy link
Copy Markdown
Contributor

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

What

  • Add e2e/features/apps/publish-app.feature with a first-publish happy-path scenario tagged @apps @authenticated @core
  • Add e2e/features/step-definitions/apps/publish-app.steps.ts with steps for API app creation, publish panel interaction, and published
    state assertion

Why

The publish flow is a P0 business path with zero E2E coverage. Any regression in the Publish button or the publish API would be invisible
until users reported it in production. This scenario closes the "create → publish" minimum loop for chatbot apps using the real API, without
requiring a live LLM or any additional infrastructure.

Effect

  • --tags @core now validates that the publish popover opens, the "Publish Update" button triggers the API, and the button transitions to
    "Published" state
  • App teardown is handled automatically by the existing After hook via createdAppIds
  • Note: a {string} app has been created via API and I navigate to the app detail page are duplicated from test/app-detail-navigation
    (not yet merged); these should be consolidated into common/ when both PRs land

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@Jingyi-Dify Jingyi-Dify requested review from iamjoel and lyzno1 April 23, 2026 01:40
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 23, 2026
…mmon

- Navigate to chatbot app by clicking from app list instead of bare /app/{id}
  URL which never redirects to configuration page
- Move shared step definitions (app creation, app list navigation) to
  common/app.steps.ts to prevent duplicate step errors when sibling
  PR test/app-detail-navigation merges
lyzno1
lyzno1 previously approved these changes Apr 23, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 23, 2026
- Change publish scenario from chat to workflow app: workflow publish
  calls /apps/{id}/workflows/publish which has no model-config validation,
  so it succeeds in CI without a configured LLM provider
- Add syncMinimalWorkflowDraft() API helper to seed a Start node before
  opening the app, preventing the empty-canvas onboarding modal and
  satisfying the frontend handleCheckBeforePublish start-node check
- Add 'a minimal workflow draft has been synced' Given step in common/
@Jingyi-Dify Jingyi-Dify added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 5b2c5da Apr 23, 2026
26 checks passed
@Jingyi-Dify Jingyi-Dify deleted the test/app-publish-happy-path branch April 23, 2026 05:11
asukaminato0721 pushed a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants