Skip to content

chore: update 3 api#35481

Merged
asukaminato0721 merged 2 commits intolanggenius:mainfrom
asukaminato0721:35141
Apr 22, 2026
Merged

chore: update 3 api#35481
asukaminato0721 merged 2 commits intolanggenius:mainfrom
asukaminato0721:35141

Conversation

@asukaminato0721
Copy link
Copy Markdown
Contributor

@asukaminato0721 asukaminato0721 commented Apr 22, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #35141 from codex

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@asukaminato0721 asukaminato0721 marked this pull request as ready for review April 22, 2026 05:14
Copilot AI review requested due to automatic review settings April 22, 2026 05:14
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 22, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the workspace plugin endpoint write APIs to add canonical, resource-oriented routes while keeping the historical verb-based routes as deprecated aliases (so only legacy paths are marked deprecated in OpenAPI).

Changes:

  • Introduces canonical write routes: POST /workspaces/current/endpoints, PATCH/DELETE /workspaces/current/endpoints/<id>.
  • Keeps legacy verb-based routes (/create, /update, /delete) as separate deprecated resources with explicit OpenAPI deprecation metadata.
  • Updates/extends unit tests to cover canonical routes, deprecated routes, and route/metadata registration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
api/controllers/console/workspace/endpoint.py Adds canonical collection/item resources, extracts shared helpers, and introduces deprecated alias resources with OpenAPI deprecation markers.
api/tests/unit_tests/controllers/console/workspace/test_endpoint.py Updates tests to target the new canonical resources and adds assertions for deprecation metadata + route registration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread api/controllers/console/workspace/endpoint.py
@asukaminato0721 asukaminato0721 added this pull request to the merge queue Apr 22, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 22, 2026
Merged via the queue into langgenius:main with commit 8b15334 Apr 22, 2026
31 checks passed
@asukaminato0721 asukaminato0721 deleted the 35141 branch April 22, 2026 09:05
fatelei pushed a commit that referenced this pull request Apr 24, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
asukaminato0721 added a commit to asukaminato0721/dify that referenced this pull request Apr 24, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants