-
Notifications
You must be signed in to change notification settings - Fork 258
Set both pg and mysql config #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @longbingljw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the database configuration flexibility for the plugin-daemon. It allows users to define distinct connection parameters for both PostgreSQL and MySQL within the .env file. By simply adjusting the DB_TYPE environment variable, the application will automatically load the corresponding database credentials, streamlining the process of switching between different database backends without manual modification of individual connection strings. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a flexible way to configure database connections for both PostgreSQL and MySQL by using separate environment variables and a DB_TYPE switch. The implementation is straightforward. My review includes suggestions to improve the new configuration loading logic by reducing code duplication, adding proper error handling for invalid values, and ensuring that configuration validation is not lost. I've also pointed out a potential issue with how old environment variables might be handled.
|
Hi, A huge refactor was committed to main, would you mind rebase to it? thanks |
|
Hello,thanks.This pr can be closed because my adaptation for mysql scheme wont't need change plugin-daemon code. |
Okay |
Description
Set separate USERNAME, PASSWORD, HOST, and PORT for both PostgreSQL and MySQL in the .env file, and use DB_TYPE to control which set of credentials to use for the database connection..So user can only change DB_TYPE to switch db config for plugin-daemon.
Closes #490
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
I hope this feat can be merged as fast as passible.