Skip to content

Conversation

@longbingljw
Copy link

@longbingljw longbingljw commented Nov 1, 2025

Description

Set separate USERNAME, PASSWORD, HOST, and PORT for both PostgreSQL and MySQL in the .env file, and use DB_TYPE to control which set of credentials to use for the database connection..So user can only change DB_TYPE to switch db config for plugin-daemon.
Closes #490

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

I hope this feat can be merged as fast as passible.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @longbingljw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the database configuration flexibility for the plugin-daemon. It allows users to define distinct connection parameters for both PostgreSQL and MySQL within the .env file. By simply adjusting the DB_TYPE environment variable, the application will automatically load the corresponding database credentials, streamlining the process of switching between different database backends without manual modification of individual connection strings.

Highlights

  • Flexible Database Configuration: Introduced separate environment variables for PostgreSQL and MySQL credentials (e.g., POSTGRES_USER, MYSQL_USER) in the .env.example file, allowing for distinct configurations for each database type.
  • Dynamic Database Switching: Enabled dynamic switching between PostgreSQL and MySQL configurations by setting the DB_TYPE environment variable, simplifying database setup for plugin-daemon users.
  • Configuration Loading Logic: Implemented new logic in the config package to load the appropriate database credentials (username, password, host, port) based on the DB_TYPE value, ensuring the correct connection parameters are used at runtime.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a flexible way to configure database connections for both PostgreSQL and MySQL by using separate environment variables and a DB_TYPE switch. The implementation is straightforward. My review includes suggestions to improve the new configuration loading logic by reducing code duplication, adding proper error handling for invalid values, and ensuring that configuration validation is not lost. I've also pointed out a potential issue with how old environment variables might be handled.

@Yeuoly
Copy link
Contributor

Yeuoly commented Nov 18, 2025

Hi, A huge refactor was committed to main, would you mind rebase to it? thanks

@longbingljw
Copy link
Author

Hello,thanks.This pr can be closed because my adaptation for mysql scheme wont't need change plugin-daemon code.

@Yeuoly
Copy link
Contributor

Yeuoly commented Nov 19, 2025

Hello,thanks.This pr can be closed because my adaptation for mysql scheme wont't need change plugin-daemon code.

Okay

@Yeuoly Yeuoly closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat:set both mysql and pg configs in .env

3 participants