Skip to content

Conversation

@chupark
Copy link

@chupark chupark commented Oct 30, 2025

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

PR for blow

Please provide any additional context that would help reviewers understand the changes.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chupark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the configuration options for reasoning models by adding a new parameter, MAX_COMPLETION_TOKENS. This parameter allows users to explicitly set an upper limit on the length of the generated output, which is crucial for managing response sizes and preventing premature truncation of model completions. The change ensures greater control and flexibility in how models produce their results.

Highlights

  • New Parameter Addition: Introduced MAX_COMPLETION_TOKENS as a new DefaultParameterName to control the maximum length of generated results from reasoning models.
  • Parameter Rule Definition: Defined comprehensive rules for MAX_COMPLETION_TOKENS including internationalized labels and help text (English, Chinese, Japanese, Portuguese), data type (integer), default value (64), and a valid range (1 to 2048).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new model parameter, max_completion_tokens, for reasoning models. The change is straightforward, adding a new constant and its corresponding parameter rule template. My review focuses on a maintainability concern regarding significant code duplication between the new MAX_COMPLETION_TOKENS rule and the existing MAX_TOKENS rule. Addressing this would improve the long-term health of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant