Skip to content

fix: skip waiting if error occured #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

fix: skip waiting if error occured #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6d09b4
fix: skip waiting if error occured
nht1206 Jun 9, 2025
ef21012
Update internal/core/plugin_manager/watcher.go
Yeuoly Jun 16, 2025
c35582d
fix: handle nil error channels in plugin manager
Yeuoly Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions internal/core/plugin_manager/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,18 +75,25 @@ func (p *PluginManager) handleNewLocalPlugins() {
}

for _, plugin := range plugins {
log.Info("launching local plugin: %s", plugin.PluginID())
_, launchedChan, errChan, err := p.launchLocal(plugin)
if err != nil {
log.Error("launch local plugin failed: %s", err.Error())
}

// consume error, avoid deadlock
for err := range errChan {
log.Error("plugin launch error: %s", err.Error())
// avoid receiving nil channel
if errChan != nil {
// consume error, avoid deadlock
for err := range errChan {
log.Error("plugin launch error: %s", err.Error())
}
}

// wait for plugin launched
<-launchedChan
// avoid receiving nil channel
if launchedChan != nil {
// wait for plugin launched
<-launchedChan
}
}
}

Expand Down