Skip to content

Fix string quotes in promptClients.ts#755

Merged
hassiebp merged 1 commit intolangfuse:mainfrom
budde377:patch-2
Mar 23, 2026
Merged

Fix string quotes in promptClients.ts#755
hassiebp merged 1 commit intolangfuse:mainfrom
budde377:patch-2

Conversation

@budde377
Copy link
Copy Markdown
Contributor

@budde377 budde377 commented Mar 21, 2026

Fix lint errors

Problem

Changes

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • langfuse
  • langfuse-node

Changelog notes

  • Added support for X

Disclaimer: Experimental PR review

Greptile Summary

This PR makes a trivial one-character lint fix in promptClients.ts, replacing single quotes with double quotes in a typeof item.content === "string" comparison to match the surrounding code style. No logic is changed.

  • Changed 'string'"string" on line 383 to comply with the project's double-quote linting rule.

Confidence Score: 5/5

  • This PR is safe to merge — it is a one-line cosmetic lint fix with no behavioral impact.
  • The change is purely stylistic (single → double quotes in a string literal used only in a typeof comparison). There is zero risk of runtime regressions.
  • No files require special attention.

Important Files Changed

Filename Overview
packages/client/src/prompt/promptClients.ts Single-character lint fix: changed single quotes to double quotes in a typeof string comparison (line 383) to match the rest of the file's quoting style.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["messagesWithPlaceholdersReplaced.map(item)"] --> B{typeof item === object AND item !== null AND role in item AND content in item AND typeof item.content === string}
    B -- true --> C["Return item with content rendered via mustache.render"]
    B -- false --> D["Return item as-is (placeholder or stringified value)"]
Loading

Last reviewed commit: "Fix string quotes in..."

(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 21, 2026

@budde377 is attempting to deploy a commit to the langfuse Team on Vercel.

A member of the Team first needs to authorize it.

@hassiebp
Copy link
Copy Markdown
Contributor

Thanks a lot for your contribution!

@hassiebp hassiebp merged commit 85281b2 into langfuse:main Mar 23, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants