fix ugly rendering of 'omit' in UI due to incorrect strip #2057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacoblee93
reviewed
Oct 6, 2025
jacoblee93
approved these changes
Oct 6, 2025
EugeneJinXin
deleted the
xin/fix-broken-openAI-wrapper-raw-input-rendering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LangSmith UI was showing ugly serialized objects like:
"seed": "<openai.Omit object at 0x105d91940>",
"stop": "<openai.Omit object at 0x105d91940>",
This happened because OpenAI SDK v1.106+ uses both NotGiven and
Omit sentinel types to represent optional parameters that weren't
provided, but the code only checked for NotGiven.
after fix:
