feat: allow user defined callbacks to extend graph callbacks #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqbd
previously approved these changes
Jun 16, 2025
jacoblee93
reviewed
Jun 17, 2025
jacoblee93
reviewed
Jun 17, 2025
| ...options, | ||
|
|
||
| // extend the callbacks with the ones from the config | ||
| callbacks: combineCallbacks(this.config?.callbacks, options?.callbacks), |
There was a problem hiding this comment.
Should we be adding this in other places too?
There was a problem hiding this comment.
other places being recursion limit? im not sure cc @dqbd
There was a problem hiding this comment.
for posterity: other places means other functions like stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)