Conversation
…onnections (#6702) When using an `AsyncConnectionPool`, connections are most likely† never shared by `_cursor()`. Calling `AsyncConnectionPool.connection()` removes the connection from the pool, so it cannot be used by any concurrent calls. As such, the lock inside `_cursor()` is redundant. If the pool allows more than one connection, then `_cursor()` should be allowed to be concurrently called. As far as I can tell, the only way for that to occur is between `_execute_batch()` and `sweep_ttl()`. In the current setup, if the `sweep_ttl()` operation is slow, then that delays all batch operations. This might be the trigger of the behaviour I was seeing in #6701. † In theory, someone could implement `AsyncConnectionPool` to return a shared connection, but that would be redundant in langgraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you to Conrad for putting this up!