feat: Include pagination in assistants search response#6526
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
| assistants: list[Assistant] | ||
| """The assistants returned for the current search page.""" | ||
| next: str | None | ||
| """Pagination cursor from the ``X-Pagination-Next`` response header.""" |
Contributor
There was a problem hiding this comment.
Might as well include count too.
count: int
"""Page size from the ``X-Pagination-Total`` response header."""
(or call it size)
Collaborator
Author
There was a problem hiding this comment.
Ya I was considering hat. I think I'd prefer not though, since we actually only return max(len(assistants), limit + 1) and just kept the header set for backwards compat reasons. Since this is a net-new API, I'd prefer to avoid adding rn
Open to being overruled ofc
hinthornw
force-pushed
the
wfh/sdk_py/return_pagination
branch
from
eea4d92 to
3b585a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.