You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In interopZodTransformInputSchema, need to make a shallow copy of the schema before replacing the properties rather than replacing in place to prevent mutation of underlying schema.
Doing so however breaks the OpenAI integration because it takes advantage of the underlying schema being mutated as part of the first call to toJsonSchema. Thus when it reaches toJSONSchemaV4 from zod, it already assumes that the transforms have been stripped.
Since this PR fixes the underlying mutation, this assumption no longer holds, so I have to manually make sure that the downstream schema passed to zod's toJSONSchemaV4 runs through the transform stripping logic.
Note: I was unable to determine how best to write a unit/integration test for OpenAI to ensure that it works with transform on schemas. But I was able to validate live.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Really appreciate you taking the time to open this PR, @ro0sterjam 🙏
The team is currently focused on shipping our v1 release, so we’re pausing detailed reviews for a bit. We’ll follow up within the next 2–4 weeks once things settle — thanks so much for your patience!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ro0sterjam
force-pushed
the
fix-transform-input-schema-mutate
branch
from
In
interopZodTransformInputSchema, need to make a shallow copy of the schema before replacing the properties rather than replacing in place to prevent mutation of underlying schema.Doing so however breaks the OpenAI integration because it takes advantage of the underlying schema being mutated as part of the first call to
toJsonSchema. Thus when it reachestoJSONSchemaV4from zod, it already assumes that the transforms have been stripped.Since this PR fixes the underlying mutation, this assumption no longer holds, so I have to manually make sure that the downstream schema passed to zod's
toJSONSchemaV4runs through the transform stripping logic.Note: I was unable to determine how best to write a unit/integration test for OpenAI to ensure that it works with
transformon schemas. But I was able to validate live.Fixes #9100