fix(openai/0.x): handle undefined disableStreaming to restore streaming functionality #8874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctionality The disableStreaming property was not correctly handling undefined values, causing streaming to break when fields.disableStreaming was explicitly or implicitly undefined. This occurred because the nullish coalescing operator (??) would preserve undefined instead of falling back to the default false value from the parent class. Changed the initialization to use strict boolean check (=== true) which ensures: - undefined/null/falsy values → false (preserves default behavior) - explicit true → true (disables streaming as intended) - type safety by always resulting in a boolean value This fixes the regression introduced in v0.6.10 where streaming stopped working. - Updated disableStreaming initialization in BaseChatOpenAI constructor - Added comprehensive unit tests for various input scenarios
🦋 Changeset detectedLatest commit: 7a18610 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
christian-bromann
changed the title
hntrl
approved these changes
Sep 9, 2025
6 tasks
hntrl
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backported from #8873