-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(langchain-community): add custom schema option for neon vector store #8867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
FlickDaWist
wants to merge
11
commits into
langchain-ai:main
from
FlickDaWist:fdw/custom-neon-postgres-schema
Closed
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
db4aff7
run code format
FlickDaWist 8afbea5
Merge branch 'main' into fdw/custom-neon-postgres-schema
FlickDaWist b71024d
allow null schemaName, adding info to docs
FlickDaWist 63eb63b
add info to docs neon.mdx
FlickDaWist 5ada702
remove create schema
FlickDaWist 0397d6d
Merge branch 'langchain-ai:main' into fdw/custom-neon-postgres-schema
FlickDaWist 0364463
neon unit test schemaName prop
FlickDaWist 9a18045
Merge branch 'fdw/custom-neon-postgres-schema' of https://github.com/…
FlickDaWist 51cd556
Merge branch 'langchain-ai:main' into fdw/custom-neon-postgres-schema
FlickDaWist b1ba13f
fix minor changes
FlickDaWist fa8af83
Update docs/core_docs/docs/integrations/vectorstores/neon.mdx
christian-bromann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
libs/langchain-community/src/vectorstores/tests/neon.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { test, expect, describe } from "@jest/globals"; | ||
| import { FakeEmbeddings } from "@langchain/core/utils/testing"; | ||
| import { NeonPostgres } from "../neon.js"; | ||
|
|
||
| describe("NeonPostgres schemaName handling", () => { | ||
| const fakeEmbeddings = new FakeEmbeddings(); | ||
|
|
||
| const baseConfig = { | ||
| connectionString: "postgres://user:pass@localhost:5432/db", | ||
| tableName: "vector_store", | ||
| }; | ||
|
|
||
| test("uses only tableName when schemaName is not provided", () => { | ||
| const store = new NeonPostgres(fakeEmbeddings, { | ||
| ...baseConfig, | ||
| }); | ||
|
|
||
| expect(store.schemaName).toBeUndefined(); | ||
| expect(store.computedTableName).toBe("vector_store"); | ||
| }); | ||
|
|
||
| test("uses schemaName and tableName when schemaName is provided", () => { | ||
| const store = new NeonPostgres(fakeEmbeddings, { | ||
| ...baseConfig, | ||
| schemaName: "custom_schema", | ||
| }); | ||
|
|
||
| expect(store.schemaName).toBe("custom_schema"); | ||
| expect(store.computedTableName).toBe('"custom_schema"."vector_store"'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.