Skip to content

Conversation

@jacoblee93
Copy link
Collaborator

If a LangChainTracer instance were already present in the callback manager, the if statement here would never trigger:

      if (
        tracingEnabled &&
        !callbackManager.handlers.some(
          (handler) => handler.name === "langchain_tracer"
        )
      ) {
        ...
      }

And the parent/child relationship would break.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: d7f67c1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchainjs-docs Ready Ready Preview Comment Sep 4, 2025 9:37pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchainjs-api-refs Ignored Ignored Sep 4, 2025 9:37pm

@jacoblee93 jacoblee93 merged commit 4e53005 into main Sep 4, 2025
42 checks passed
@jacoblee93 jacoblee93 deleted the jacob/tracing branch September 4, 2025 21:38
hntrl added a commit that referenced this pull request Oct 14, 2025
hntrl added a commit that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants