Skip to content

Conversation

@alumni
Copy link
Contributor

@alumni alumni commented Jun 12, 2025

Allows any identifier to be used in SAP HANA vector store, including the ones that contain non-alphanumeric characters.

This would allow the users to pass e.g.: sap.hdb.container/embeddings_table as tableName, and the special characters won't be stripped away.

const hanaDb = new HanaDB(embeddingClient, {
  connection,
  tableName: 'sap.hdb.container/embeddings_table',
});

@vercel
Copy link

vercel bot commented Jun 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 12, 2025 4:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jun 12, 2025 4:47pm

@christian-bromann
Copy link
Member

@alumni thanks for the contribution. Are you still interested in getting this landed into Langchain? It generally looks good to me and is only missing some unit tests. Let me know how you would like to move forward here?

@hntrl
Copy link
Member

hntrl commented Sep 10, 2025

rebased in #8913

@hntrl hntrl closed this Sep 10, 2025
@alumni
Copy link
Contributor Author

alumni commented Sep 11, 2025

@christian-bromann @hntrl sorry, I'm not that much online lately, so I'm slow to reply. Thanks for taking over the PR.

I'll likely extract the HANA vector store (or the TypeORM one) into a separate package, currently the community package is adding some unwanted dependencies to our large monorepo, and it seems it's simpler to take only the parts that we need.

@christian-bromann
Copy link
Member

@alumni no worries and yes, that is the direction we are suggesting to folks now. We are working on finding an ideal way to highlight these community contributions, so please let us know once you have something out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants