fix(core): applied secrets_map in load() to plain string values #33618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes the bug in the
load()function where secret placeholders in plain dicts were not replaced, even if they match a key insecrets_map, and adds a test case.Example:
Before this change, printing
api_keyinresultwould output"__SECRET_API_KEY__". Now, it will properly output"secret_key_1234".Issue: Fixes #31804
Dependencies: None
make format,make lint, andmake testhave all passed on my machine.