-
Notifications
You must be signed in to change notification settings - Fork 316
support loading text prompts #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-brobot
commented
Mar 3, 2025
vbarda
reviewed
Mar 12, 2025
vbarda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding -- looks good overall! Added a few small comments - could you add usage example to the PR description?
Contributor
Author
|
@vbarda thanks for the feedback. i think i addressed everything. lmk if there's anything else i can do to help |
vbarda
reviewed
Mar 13, 2025
use value errors instead of custom exception classes
vbarda
approved these changes
Mar 15, 2025
|
Thank you! |
ssmails
pushed a commit
to ssmails/langchain-mcp-adapters
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details in #11
any feedback welcome, including nits :)
usage example: