Skip to content

fix: handle empty tool response #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix: handle empty tool response #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion langchain_mcp_adapters/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ def _convert_call_tool_result(
non_text_contents.append(content)

tool_content: str | list[str] = [content.text for content in text_contents]
if len(text_contents) == 1:
if not text_contents:
tool_content = ""
elif len(text_contents) == 1:
tool_content = tool_content[0]

if call_tool_result.isError:
Expand Down
13 changes: 13 additions & 0 deletions tests/test_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
)


def test_convert_empty_text_content():
# Test with a single text content
result = CallToolResult(
content=[],
isError=False,
)

text_content, non_text_content = _convert_call_tool_result(result)

assert text_content == ""
assert non_text_content is None


def test_convert_single_text_content():
# Test with a single text content
result = CallToolResult(
Expand Down