feat: Add chat_template_kwargs to supported chat params #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to specify chat_template_kwargs like other chat params (e.g. temperature) on the ChatWatsonx constructor or as a kwarg to ChatWatsonx.invoke/generate/etc. Prior to this change, one had to specify chat_template_kwargs under the params argument. But this is cumbersome, different that other LangChain chat integrations, and different from other chat params like all the others named in _get_supported_chat_params(). Signed-off-by: BJ Hargrave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the user to specify
chat_template_kwargslike other chat params (e.g.temperature) on theChatWatsonxconstructor or as a kwarg toChatWatsonx.invoke/generate/etc.Prior to this change, one had to specify
chat_template_kwargsunder theparamsargument. But this is cumbersome, different that other LangChain chat integrations, and different from other chat params like all the others named in_get_supported_chat_params().Relevant issues
Fixes #138
Type
🆕 New Feature
Changes(optional)
Testing(optional)
Note(optional)