-
Notifications
You must be signed in to change notification settings - Fork 319
docs(community): update docstrings for reference docs #1237 #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(community): update docstrings for reference docs #1237 #1255
Conversation
|
Hey @mdrxy! here is the PR for the community pkg for new ref docs. Working on these docstring updates raised some questions about reference docs patterns: 1. Documenting private method details in class docstrings: 2. Example detail level in reference docs: 3. Package organization in docs: PS: Asking this not to give you more trouble, just to say I can help with some of those if they're not already planned |
Appreciate the checking in and feel free to reach out on Slack if quicker |
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Outdated
Show resolved
Hide resolved
|
@mdrxy I'll keep an eye out for the .md patch from ChatOpenAI and take a look at mkdocs.yml to help with the docs for the Google packages Google Sheets examples in this PR:
Thanks again for the review and clarifications! |
|
Pasting this here just to double check- Griffe warnings from our build (but not from this branch so the problem may already be resolved): |
|
Hey @mdrxy, sorry for the delay. I fixed the Griffe warnings in PR branch (1255). Retested locally, only mkdocs_autorefs warnings remain. ps: rebased into main :) |
3b9d206 to
d98f862
Compare
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/create_spreadsheet_tool.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/get_spreadsheet_info.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_google_community/sheets/read_sheet_tools.py
Outdated
Show resolved
Hide resolved
| Args: | ||
| spreadsheet_id: ID of the spreadsheet to read from. | ||
| data_filters: List of DataFilter objects specifying ranges to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| data_filters: List of DataFilter objects specifying ranges to read. | |
| data_filters: List of `DataFilter` objects specifying ranges to read. |
Description
Updated docstrings in
langchain-google-communityto be in accordance with the new reference docs site.Relevant issues
#1237
Type
📖 Documentation