Skip to content

Activate ruff rules BLE #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Activate ruff rules BLE #61

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae3e304
Activate ruff rules BLE
cbornet Aug 27, 2024
e822f0e
Merge branch 'main' into ruff-rules-ble
Aug 28, 2024
1cad067
nit: backward compat in the NVIDIA_VECTORIZE_AVAILABLE parsing
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion libs/astradb/tests/integration_tests/test_vectorstores.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,15 @@

def is_nvidia_vector_service_available() -> bool:
# For the time being, this is manually controlled
return os.getenv("NVIDIA_VECTORIZE_AVAILABLE") == "1"
if os.environ.get("NVIDIA_VECTORIZE_AVAILABLE"):
try:
# any non-zero counts as true:
return int(os.environ["NVIDIA_VECTORIZE_AVAILABLE"]) != 0
except (TypeError, ValueError):
Copy link
Collaborator Author

@cbornet cbornet Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it can be TypeError

Copy link
Collaborator Author

@cbornet cbornet Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would do ˋreturn int(os.getenv(NVIDIA, "0"))ˋ and remove the if clause.

# the env var has unparsable contents:
return False
else:
return False


@pytest.fixture
Expand Down