Skip to content

Activate ruff ANN rules #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Activate ruff ANN rules #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e674c
Activate ruff ANN rules
cbornet Aug 27, 2024
0ca4aa6
Merge branch 'main' into ruff-rules-ann
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/astradb/langchain_astradb/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
self.async_collection = self.astra_env.async_collection

@abstractmethod
def decode_value(self, value: Any) -> V | None:
def decode_value(self, value: Any) -> V | None: # noqa: ANN401
"""Decodes value from Astra DB."""

@abstractmethod
def encode_value(self, value: V | None) -> Any:
def encode_value(self, value: V | None) -> Any: # noqa: ANN401
"""Encodes value for Astra DB."""

@override
Expand Down
3 changes: 2 additions & 1 deletion libs/astradb/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ pydocstyle.convention = "google"
pep8-naming.classmethod-decorators = [
"langchain_core.pydantic_v1.validator",
]
flake8-annotations.allow-star-arg-any = true
flake8-annotations.mypy-init-return = true
select = ["ALL"]
ignore = [
"ANN", # Already checked by mypy
"C90", # Do we want to activate (complexity) ?
"COM812", # Messes with the formatter
"ERA", # Do we want to activate (no commented code) ?
Expand Down