Refactor similarity_search methods + forbid by-vector if vectorize #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at simplifying the chain of calls around the various
[a]similarity_search_*methods for the vector store.The main goal is readability and reduction of duplicated code: the former via a rationalization of which method reformats which one's result; the latter through shared "by sort" function where the
sortparameter can reflect both the vectorize and the regular vector-based approaches.Additionally, access of by-vector ANN calls is now raising an exception if the store is set to use server-side embeddings (i.e. Vectorize).
Attached is the new flow of the chain of calls around the similarity-search methods.