Skip to content

Activate ruff PERF rule #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Activate ruff PERF rule #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20bf06b
Activate ruff PERF rule
cbornet Aug 23, 2024
a9fd74e
Merge branch 'main' into ruff-perf
Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libs/astradb/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ ignore = [
"ERA", # Do we want to activate (no commented code) ?
"FBT", # Do we want to activate (boolean trap) ?
"ISC001", # Messes with the formatter
"PERF203", # Incorrect detection
"PLR09", # TODO: do we enforce these ones (complexity) ?
"PTH", # Do we want to activate (use pathlib) ?

Expand Down
2 changes: 1 addition & 1 deletion libs/astradb/scripts/check_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
for file in files:
try:
SourceFileLoader("x", file).load_module()
except Exception:
except (ImportError, FileNotFoundError): # noqa: PERF203
has_faillure = True
print(file)
traceback.print_exc()
Expand Down