feat: Integrate Valkey with LangGraph LLM Cache #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@seaofawareness |
Apply pytest.importorskip() pattern to cache tests: - test_valkey_cache_unit.py (66 tests) - test_valkey_cache_integration.py (22 tests) Fixes NameError with @patch decorator on Python 3.10.
michaelnchin
requested changes
Oct 30, 2025
Collaborator
michaelnchin
left a comment
michaelnchin
left a comment
There was a problem hiding this comment.
@seaofawareness looks great overall, couple minor comments.
libs/langgraph-checkpoint-aws/langgraph_checkpoint_aws/cache/valkey/cache.py
Outdated
Show resolved
Hide resolved
Changes: - Removed JsonPlusSerializer import (obsolete in 3.0) - Updated test assertions to check for serde presence instead of type - Used default cache instance to get serializer for custom serde test docs(samples): update valkey_cache.ipynb to use Claude 3.7 Sonnet Removed references to Haiku model and updated to reflect the actual model being used (Claude 3.7 Sonnet).
michaelnchin
approved these changes
Oct 30, 2025
Collaborator
michaelnchin
left a comment
michaelnchin
left a comment
There was a problem hiding this comment.
LGTM - thanks @seaofawareness !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables use of Valkey to cache LLM responses in LangGraph