Update Makefile #302
Merged
Update Makefile #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
reviewed
Dec 10, 2024
libs/aws/Makefile
Outdated
| tests: ## Run all Tests | ||
| poetry run pytest $(TEST_FILE) | ||
|
|
||
| test: ## Run Individual Test: make test TEST_FILE=test.py |
There was a problem hiding this comment.
Nice! Like the sample commands.
guilt
force-pushed
the
guilt-Build-Fixes
branch
2 times, most recently
from
f0bd840 to
7eef101
Compare
Co-authored-by: Piyush Jain <[email protected]>
guilt
force-pushed
the
guilt-Build-Fixes
branch
from
7eef101 to
41c214f
Compare
murilosimao
pushed a commit
to murilosimao/langchain-aws
that referenced
this pull request
Oct 29, 2025
# Issue or Problem Addressed For a new Developer who is starting with the development, list of commands to learn in `make` can be exhausting. # Description - This PR simplifies the setup of a new developer environment by listing all the targets that `Makefile`. - Adding a new target with inline help ensures that the developer can document this without requiring to add in a separate `help` section of Makefile. - This PR runs formatting and spell check fixes and corrects some scripts. # Type of change Please delete options that are not relevant. - [X] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) # How Has This Been Tested? This as tested on my Laptop. ## List of Tests Added N/A ## Test Procedure - [ ] `make` now lists all help targets <img width="1518" alt="Screenshot 2024-12-10 at 2 58 52 PM" src="https://github.com/user-attachments/assets/ad6cf3b7-8a79-43e9-af35-e598e45671c9"> ## Test Configuration - Python Version: `3.12.4` - OS/Distribution: `Darwin 23.6.0 Darwin Kernel Version 23.6.0` # Review Checklist: - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [X] I have no changes that break existing user workflows. If so, I am providing a deprecation path - [X] I have added tests that prove my fix is effective or that my feature works - [X] New and existing unit tests pass locally with my changes Co-authored-by: Piyush Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or Problem Addressed
For a new Developer who is starting with the development, list of commands to learn in
makecan be exhausting.Description
Makefile.helpsection of Makefile.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This as tested on my Laptop.
List of Tests Added
N/A
Test Procedure
makenow lists all help targetsTest Configuration
3.12.4Darwin 23.6.0 Darwin Kernel Version 23.6.0Review Checklist: