Skip to content

Conversation

@yanghua
Copy link
Collaborator

@yanghua yanghua commented Nov 20, 2025

No description provided.

@yanghua yanghua marked this pull request as ready for review November 20, 2025 11:47
@yanghua yanghua requested a review from jackye1995 November 20, 2025 12:20
Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is always a debate of do we want to create more util methods for testing, but those might become limiting factors in writing tests. But having these at least limited in the specific test mod for delta.rs seems good to me

@jackye1995 jackye1995 changed the title refactor: delta.rs tests refactor: add helper functions to delta.rs tests Nov 20, 2025
@jackye1995 jackye1995 merged commit feaf1f6 into lance-format:main Nov 20, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants