Skip to content

Conversation

@Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Nov 11, 2025

This PR will refactor our python dep management into uv entirely.


This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.

@github-actions github-actions bot added python ci Github Action or Test issues labels Nov 11, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Xuanwo Xuanwo marked this pull request as draft November 11, 2025 10:48
Comment on lines +211 to +249
name: Python Torch Tests (3.11 Linux)
runs-on: "ubuntu-24.04"
timeout-minutes: 45
defaults:
run:
shell: bash
working-directory: python
env:
UV_PYTHON: "3.11"
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
lfs: true
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.11
- name: Install uv
uses: astral-sh/setup-uv@v6
with:
enable-cache: true
- uses: Swatinem/rust-cache@v2
with:
workspaces: python
prefix-key: ${{ env.CACHE_PREFIX }}
cache-targets: false
cache-workspace-crates: true
- name: Install system dependencies
run: |
sudo apt update
sudo apt install -y protobuf-compiler libssl-dev
- name: Sync torch environment
run: |
uv sync --frozen --project python/tests/torch_tests
- name: Run torch tests
run: make test-torch

pandas:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Comment on lines +250 to +288
name: Python Pandas/SQL Tests (3.11 Linux)
runs-on: "ubuntu-24.04"
timeout-minutes: 45
defaults:
run:
shell: bash
working-directory: python
env:
UV_PYTHON: "3.11"
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
lfs: true
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.11
- name: Install uv
uses: astral-sh/setup-uv@v6
with:
enable-cache: true
- uses: Swatinem/rust-cache@v2
with:
workspaces: python
prefix-key: ${{ env.CACHE_PREFIX }}
cache-targets: false
cache-workspace-crates: true
- name: Install system dependencies
run: |
sudo apt update
sudo apt install -y protobuf-compiler libssl-dev
- name: Sync pandas environment
run: |
uv sync --frozen --project python/tests/pandas_tests
- name: Run pandas tests
run: make test-pandas

tensorflow:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 13 days ago

To fix this issue, you should set an explicit permissions block in the workflow, restricting permissions to the minimum required. The best approach is to add permissions: contents: read at the workflow root—line 2, after the name: declaration—so that all jobs inherit this minimal permission unless they require more or override it. This satisfies principle of least privilege and the CodeQL rule. No additional imports or methods are needed in a GitHub Actions workflow file; the edit is purely to the YAML.

If any later jobs are shown to require additional permissions, they would need overrides, but for the sections shown (torch, pandas, tensorflow, etc.), only code checkout and test running occurs, so contents: read should be sufficient.


Suggested changeset 1
.github/workflows/python.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
--- a/.github/workflows/python.yml
+++ b/.github/workflows/python.yml
@@ -1,4 +1,6 @@
 name: Python
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: Python
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
Xuanwo added a commit that referenced this pull request Nov 19, 2025
This PR is based on #5210

---

This PR intends to add a blob arrow extension type (aka, logical type)
in lance.

**This PR was primarily authored with Codex using GPT-5-Codex and then
hand-reviewed by me. I AM responsible for every change made in this PR.
I aimed to keep it aligned with our goals, though I may have missed
minor issues. Please flag anything that feels off, I'll fix it
quickly.**

---------

Signed-off-by: Xuanwo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants