Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions rust/lance-datafusion/src/exec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,21 @@ pub struct ExecutionSummaryCounts {
pub all_counts: HashMap<String, usize>,
}

impl ExecutionSummaryCounts {
/// Create a new ExecutionSummaryCounts with all values initialized to zero
pub fn new() -> Self {
Self::default()
}

/// Create a new ExecutionSummaryCounts with only custom counts
pub fn with_counts(counts: impl IntoIterator<Item = (impl Into<String>, usize)>) -> Self {
Self {
all_counts: counts.into_iter().map(|(k, v)| (k.into(), v)).collect(),
..Default::default()
}
}
}

fn visit_node(node: &dyn ExecutionPlan, counts: &mut ExecutionSummaryCounts) {
if let Some(metrics) = node.metrics() {
for (metric_name, count) in metrics.iter_counts() {
Expand Down
2 changes: 1 addition & 1 deletion rust/lance-tools/src/meta.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ impl LanceToolFileMetadata {
.open_file(&path, &CachedFileSize::unknown())
.await?;
let file_metadata = FileReader::read_all_metadata(&file_scheduler).await?;
let lance_tool_file_metadata = LanceToolFileMetadata { file_metadata };
let lance_tool_file_metadata = Self { file_metadata };
Ok(lance_tool_file_metadata)
}
}
Expand Down
8 changes: 1 addition & 7 deletions rust/lance/src/dataset.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8873,12 +8873,7 @@ mod tests {
}

fn make_tx(read_version: u64) -> Transaction {
Transaction::new(
read_version,
Operation::Append { fragments: vec![] },
None,
None,
)
Transaction::new(read_version, Operation::Append { fragments: vec![] }, None)
}

async fn delete_external_tx_file(ds: &Dataset) {
Expand Down Expand Up @@ -8939,7 +8934,6 @@ mod tests {
ds.load_indices().await.unwrap().as_ref().clone(),
&tx_file,
&ManifestWriteConfig::default(),
None,
)
.unwrap();
let location = write_manifest_file(
Expand Down
Loading
Loading