Add Psalm, Drop PHP 7.3 and Update Coding Standard to 2.3#21
Merged
Ocramius merged 8 commits intolaminas:1.7.xfrom Jan 10, 2022
Merged
Add Psalm, Drop PHP 7.3 and Update Coding Standard to 2.3#21Ocramius merged 8 commits intolaminas:1.7.xfrom
Ocramius merged 8 commits intolaminas:1.7.xfrom
Conversation
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
requested changes
Jan 9, 2022
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
commented
Jan 10, 2022
| * Messages from previous request | ||
| * @var array | ||
| * | ||
| * @var array<string, SplQueue> |
Member
Author
There was a problem hiding this comment.
How do I get SplQueue<array-key, string> without Psalm complaining about too many types? Tried @psalm-type MessageList = SplQueue<array-key, string> but psalm didn't like that either - I think it's because SplQueue is from stdlib as opposed to native??
Member
There was a problem hiding this comment.
It should be possible if you reference \SplQueue, instead of the one provided by laminas/laminas-stdlib here 🤔
Alternatively:
\Laminas\Stdlib\SplQueue&\SplQueue<TKey, TValue>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8 - Add Psalm integration
Drops support for 7.3
Update Laminas Coding Standard to 2.3