Skip to content

Conversation

@LordSimal
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

PHP 8.5 is on its way so any library using this as a base should be able to composer install with this package as part of their dependency

We - as the CakePHP Core Team - currently are not able to test PHP 8.5 due to this version constraint missing.

I'd personally would change that to ^8.1 but I guess you selectively wan't to support new minor versions.

@froschdesign
Copy link
Member

Without PHP 8.5 in the CI pipeline, this cannot be checked and merged. We have to wait until a suitable pre-release version of PHP can be integrated into the CI pipeline.
Anything else would mean we are running across the street with our eyes closed.

@LordSimal
Copy link
Contributor Author

Thanks for the quick response. totally understandable, I will be patient 👍🏻 😉

@froschdesign
Copy link
Member

Thank you for your understanding! 👍
Unfortunately, PHP is not backward compatible, and in order to ensure quality, it must first be tested with the appropriate version.

@arshidkv12
Copy link

I ran PHPUnit tests with PHP 8.5.0beta1 and didn’t notice any issues. https://php.watch/versions/8.5/releases/8.5.0beta1

@LordSimal
Copy link
Contributor Author

RC1 is here, so how about now? 😁
https://www.php.net/archive/2025.php#2025-09-25-3

@gsteel
Copy link
Member

gsteel commented Sep 26, 2025

Nothing will happen until 8.5 is available in Debian packages. After that, CI containers will need to be updated before laminas & mezzio libs can be tested under 8.5. Support for 8.5 will only be merged and released once CI is passing

@froschdesign froschdesign moved this to In Progress in PHP 8.5 Oct 10, 2025
@Ocramius
Copy link
Member

Given #209, this should now be rebased

@LordSimal
Copy link
Contributor Author

So now CI is failing because of vimeo/psalm#11541

@Xerkus
Copy link
Member

Xerkus commented Oct 11, 2025

Also drop PHP 8.1 at the same time. We would not be waiting until end of december.

Here is an example of the changes you would need to do to make it work mezzio/mezzio-session#78
Except for phpunit changes as 11 is currently not installable due to another dependency preventing it php-http/psr7-integration-tests#80

@Xerkus Xerkus changed the base branch from 3.7.x to 3.8.x October 11, 2025 20:39
@LordSimal LordSimal changed the title add PHP 8.5 add PHP 8.5 and remove 8.1 Oct 12, 2025
@Ocramius Ocramius modified the milestone: 3.8.0 Oct 12, 2025
@Ocramius
Copy link
Member

composer.lock needs refreshing too, so does config -> platform -> php in composer.json

@LordSimal
Copy link
Contributor Author

Sorry, didn't know that. I just did a composer update -W with PHP 8.2, is that correct?

@Ocramius
Copy link
Member

Ocramius commented Oct 12, 2025

@LordSimal no worries, can't know what to do without it being somehow learned somewhere :-)

Anyway, we'll need to tell PHP 8.5 CI to ignore dependency checks for the time being.

See https://github.com/laminas/laminas-stdlib/blob/b1c81514cfe158aadf724c42b34d3d0a8164c096/.laminas-ci.json#L2-L3 for an example

@LordSimal LordSimal marked this pull request as ready for review October 12, 2025 13:22
@Xerkus Xerkus added this to the 3.8.0 milestone Oct 12, 2025
Copy link
Member

@Xerkus Xerkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP Deprecated:  Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in /github/workspace/test/ResponseTest.php on line 112

@LordSimal please drop the function from the test and we are good to go.

Signed-off-by: Kevin Pfeifer <[email protected]>
@Xerkus Xerkus merged commit 60c1829 into laminas:3.8.x Oct 12, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in PHP 8.5 Oct 12, 2025
@Xerkus
Copy link
Member

Xerkus commented Oct 12, 2025

@LordSimal thank you.

@Xerkus Xerkus linked an issue Oct 12, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add support for PHP 8.5

6 participants