-
-
Notifications
You must be signed in to change notification settings - Fork 74
add PHP 8.5 and remove 8.1 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Without PHP 8.5 in the CI pipeline, this cannot be checked and merged. We have to wait until a suitable pre-release version of PHP can be integrated into the CI pipeline. |
|
Thanks for the quick response. totally understandable, I will be patient 👍🏻 😉 |
|
Thank you for your understanding! 👍 |
|
I ran PHPUnit tests with PHP 8.5.0beta1 and didn’t notice any issues. https://php.watch/versions/8.5/releases/8.5.0beta1 |
|
RC1 is here, so how about now? 😁 |
|
Nothing will happen until 8.5 is available in Debian packages. After that, CI containers will need to be updated before laminas & mezzio libs can be tested under 8.5. Support for 8.5 will only be merged and released once CI is passing |
|
Given #209, this should now be rebased |
|
So now CI is failing because of vimeo/psalm#11541 |
|
Also drop PHP 8.1 at the same time. We would not be waiting until end of december. Here is an example of the changes you would need to do to make it work mezzio/mezzio-session#78 |
|
|
|
Sorry, didn't know that. I just did a composer update -W with PHP 8.2, is that correct? |
|
@LordSimal no worries, can't know what to do without it being somehow learned somewhere :-) Anyway, we'll need to tell PHP 8.5 CI to ignore dependency checks for the time being. See https://github.com/laminas/laminas-stdlib/blob/b1c81514cfe158aadf724c42b34d3d0a8164c096/.laminas-ci.json#L2-L3 for an example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP Deprecated: Function curl_close() is deprecated since 8.5, as it has no effect since PHP 8.0 in /github/workspace/test/ResponseTest.php on line 112
@LordSimal please drop the function from the test and we are good to go.
Signed-off-by: Kevin Pfeifer <[email protected]>
|
@LordSimal thank you. |
Description
PHP 8.5 is on its way so any library using this as a base should be able to
composer installwith this package as part of their dependencyWe - as the CakePHP Core Team - currently are not able to test PHP 8.5 due to this version constraint missing.
I'd personally would change that to
^8.1but I guess you selectively wan't to support new minor versions.