Skip to content

fix: returns rejected promise instead throw error when call provider methods #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

fix: returns rejected promise instead throw error when call provider methods #500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e404fb1
fix: returns rejected promise instead throw error when call provider …
Milly May 6, 2024
d4c15a5
fix: avoid error of `readdir()`
Milly May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion autoload/fern/scheme/file/util.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ if exists('*readdir')
let l:Profile = fern#profile#start('fern#scheme#file#util#list_entries_readdir')
let s = s:is_windows ? '\' : '/'
let p = a:path[-1:] ==# s ? a:path : (a:path . s)
return s:Promise.resolve(readdir(a:path))
silent! let children = readdir(a:path)
Copy link
Owner

@lambdalisue lambdalisue May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝

readdir returns an empty list on error.

Copy link
Contributor Author

@Milly Milly May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readdir returns an empty list on error, AND generate an exception.
If it called in function with abort, The function exits with an exception before the assignment.

return s:Promise.resolve(children)
\.then(s:AsyncLambda.map_f({ v -> p . v }))
\.finally({ -> Profile() })
endfunction
Expand Down