Fix failures to list self-referenced symlink #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdalisue
approved these changes
Mar 21, 2022
Owner
|
Thanks for your contribution. I'll merge it after CI success 👍 |
Previous fern.vim can't list file entries containing even one self-referenced symlink because a `find` command invoked in the background emits an error such as `Too many levels of symbolic links` by the `-follow` option. The option tries to dereference symlinks in listing files. But we only need to dereference symlinks on the command line, but not dereference symlinks in listing files. So we should use the `-H` option, which doesn't dereference symlinks except on the command line, instead of the `-follow` option. This problem happens on Linux, but not macOS. The `find` command installed in macOS by default doesn't emit errors in the situation above.
a5ob7r
force-pushed
the
fix_list_self_ref_link
branch
from
65f4ff4 to
8d2c3c6
Compare
Contributor
Author
|
@lambdalisue I did rebase to the current master. Could you approve to run GHA workflows again? |
Contributor
Author
|
@lambdalisue Thank you for your reapprove. |
Contributor
Author
|
@lambdalisue Hmm, a CI job is failed, and the error step is a vim building. I think the step probably be not directly related to this patch. Similar errors can be found in some old jobs. Does this error sometimes happens? And what should I do to resolve this? This is a job where a similar error happened. |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fern.vim can't list file entries containing even one self-referenced symlink because a
findcommand invoked in the background emits an error such asToo many levels of symbolic linksby the-followoption. The option tries to dereference symlinks in listing files. But we only need to dereference symlinks on the command line, but not dereference symlinks in listing files. So we should use the-Hoption, which doesn't dereference symlinks except on the command line, instead of the-followoption.This problem happens on Linux, but not macOS. The
findcommand installed in macOS by default doesn't emit errors in the situation above.Fixes #384.