Skip to content

Conversation

@fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Nov 28, 2025

This reverts commit c7ec3b3.

Motivation
Multiple tests for Paris fork started failing on hive eest consume-engine and consume-rlp suites as of merging this PR. Noticed by Hive Daily Report workflow

Description

@github-actions
Copy link

Lines of code report

Total lines added: 104
Total lines removed: 8
Total lines changed: 112

Detailed view
+--------------------------------------------------------------+-------+------+
| File                                                         | Lines | Diff |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs                       | 1515  | -1   |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/constants.rs                        | 14    | +1   |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/mempool.rs                          | 736   | +26  |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/payload.rs                          | 676   | +4   |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/block.rs                          | 881   | -4   |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/genesis.rs                        | 962   | +66  |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/block_producer/payload_builder.rs | 195   | +7   |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/blobs.rs                 | 137   | -2   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state/deserialize.rs                 | 416   | -1   |
+--------------------------------------------------------------+-------+------+

@github-actions
Copy link

Benchmark Results Comparison

No significant difference was registered for any benchmark run.

Detailed Results

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
main_revm_BubbleSort 2.825 ± 0.018 2.809 2.867 1.00 ± 0.01
main_levm_BubbleSort 2.886 ± 0.016 2.873 2.926 1.02 ± 0.01
pr_revm_BubbleSort 2.819 ± 0.018 2.806 2.869 1.00
pr_levm_BubbleSort 2.888 ± 0.015 2.876 2.921 1.02 ± 0.01

Benchmark Results: ERC20Approval

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Approval 921.1 ± 9.9 913.1 941.7 1.01 ± 0.01
main_levm_ERC20Approval 1019.4 ± 5.3 1014.9 1032.2 1.11 ± 0.01
pr_revm_ERC20Approval 916.0 ± 2.7 911.9 920.6 1.00
pr_levm_ERC20Approval 1022.2 ± 3.0 1018.6 1027.8 1.12 ± 0.00

Benchmark Results: ERC20Mint

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Mint 120.9 ± 1.8 119.7 125.7 1.00
main_levm_ERC20Mint 148.3 ± 1.1 147.1 149.6 1.23 ± 0.02
pr_revm_ERC20Mint 121.1 ± 1.7 119.8 125.0 1.00 ± 0.02
pr_levm_ERC20Mint 148.6 ± 1.6 147.0 152.3 1.23 ± 0.02

Benchmark Results: ERC20Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Transfer 218.8 ± 5.7 216.3 235.0 1.00 ± 0.03
main_levm_ERC20Transfer 258.1 ± 0.8 257.3 259.7 1.18 ± 0.02
pr_revm_ERC20Transfer 218.8 ± 3.1 215.9 225.2 1.00
pr_levm_ERC20Transfer 259.4 ± 2.9 256.9 265.7 1.19 ± 0.02

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Factorial 184.6 ± 3.8 182.7 195.4 1.00 ± 0.02
main_levm_Factorial 218.7 ± 5.6 215.4 231.8 1.19 ± 0.03
pr_revm_Factorial 183.8 ± 1.2 182.8 186.6 1.00
pr_levm_Factorial 215.9 ± 0.9 214.9 218.1 1.17 ± 0.01

Benchmark Results: FactorialRecursive

Command Mean [s] Min [s] Max [s] Relative
main_revm_FactorialRecursive 1.347 ± 0.020 1.323 1.383 1.00 ± 0.03
main_levm_FactorialRecursive 6.416 ± 0.052 6.337 6.502 4.77 ± 0.11
pr_revm_FactorialRecursive 1.346 ± 0.029 1.307 1.390 1.00
pr_levm_FactorialRecursive 6.441 ± 0.070 6.330 6.605 4.78 ± 0.11

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Fibonacci 154.2 ± 4.4 151.9 166.5 1.01 ± 0.03
main_levm_Fibonacci 197.7 ± 4.1 195.7 209.1 1.29 ± 0.03
pr_revm_Fibonacci 153.2 ± 1.4 151.8 156.4 1.00
pr_levm_Fibonacci 198.8 ± 5.4 195.8 212.9 1.30 ± 0.04

Benchmark Results: FibonacciRecursive

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_FibonacciRecursive 716.0 ± 5.4 708.5 726.3 1.15 ± 0.01
main_levm_FibonacciRecursive 621.5 ± 4.8 615.7 633.4 1.00
pr_revm_FibonacciRecursive 720.6 ± 10.4 704.2 738.5 1.16 ± 0.02
pr_levm_FibonacciRecursive 625.7 ± 11.9 616.4 656.8 1.01 ± 0.02

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ManyHashes 7.9 ± 0.1 7.8 8.0 1.01 ± 0.01
main_levm_ManyHashes 8.5 ± 0.1 8.4 8.8 1.09 ± 0.01
pr_revm_ManyHashes 7.8 ± 0.0 7.8 7.9 1.00
pr_levm_ManyHashes 8.5 ± 0.1 8.4 8.7 1.09 ± 0.01

Benchmark Results: MstoreBench

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_MstoreBench 262.1 ± 3.9 257.5 268.6 1.24 ± 0.02
main_levm_MstoreBench 216.2 ± 9.2 209.7 240.0 1.02 ± 0.04
pr_revm_MstoreBench 260.0 ± 2.8 257.8 266.8 1.23 ± 0.02
pr_levm_MstoreBench 211.6 ± 1.5 208.9 213.3 1.00

Benchmark Results: Push

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Push 242.1 ± 1.1 240.9 244.7 1.00
main_levm_Push 249.7 ± 15.3 241.7 292.1 1.03 ± 0.06
pr_revm_Push 242.2 ± 1.0 241.0 244.2 1.00 ± 0.01
pr_levm_Push 245.4 ± 8.2 242.0 268.6 1.01 ± 0.03

Benchmark Results: SstoreBench_no_opt

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_SstoreBench_no_opt 145.9 ± 8.6 142.5 170.2 1.84 ± 0.12
main_levm_SstoreBench_no_opt 79.3 ± 2.3 77.4 85.0 1.00
pr_revm_SstoreBench_no_opt 144.4 ± 2.4 142.8 149.8 1.82 ± 0.06
pr_levm_SstoreBench_no_opt 79.6 ± 3.8 77.5 90.1 1.00 ± 0.06

@fmoletta fmoletta changed the title [DEBUG] Revert "refactor(l1): refactor chainconfig (#5233)" fix(l1): revert "refactor(l1): refactor chainconfig (#5233)" Dec 1, 2025
@github-actions github-actions bot added the L1 Ethereum client label Dec 1, 2025
@fmoletta fmoletta marked this pull request as ready for review December 1, 2025 16:00
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Dec 1, 2025
@fmoletta fmoletta changed the title fix(l1): revert "refactor(l1): refactor chainconfig (#5233)" fix(l1): revert "refactor chainconfig (#5233)" Dec 1, 2025
@Arkenan Arkenan added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 1bebff3 Dec 1, 2025
86 of 93 checks passed
@Arkenan Arkenan deleted the revert-c7ec3b323b5d823857e8fe68c30bba95f82340da branch December 1, 2025 16:21
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Dec 1, 2025
fmoletta added a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants