-
Notifications
You must be signed in to change notification settings - Fork 154
refactor(l1,l2,levm): remove dead code #5452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fdfe677
remove dead code
iovoid c70b7b6
remove more dead code
iovoid 3c30aed
restore execution_witness_from_rpc_chain_config and add comment menti…
iovoid 3bcb75e
restore l2 sdk
iovoid c96149a
fmt
iovoid e601ecb
Merge branch 'main' into remove_dead_pub
iovoid 588a3bf
restore l1 client functions
iovoid 4f52946
bring back correct version
iovoid 68bdae9
remove unused import
iovoid 8dc41c2
fmt
iovoid 454e767
restore changelog
iovoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,6 @@ use ethrex_p2p::{ | |
| sync::SyncMode, | ||
| types::{Node, NodeRecord}, | ||
| }; | ||
| use ethrex_rlp::decode::RLPDecode; | ||
| use hex::FromHexError; | ||
| use secp256k1::{PublicKey, SecretKey}; | ||
| use serde::{Deserialize, Serialize}; | ||
|
|
@@ -65,13 +64,6 @@ pub fn read_chain_file(chain_rlp_path: &str) -> Vec<Block> { | |
| decode::chain_file(chain_file).expect("Failed to decode chain rlp file") | ||
| } | ||
|
|
||
| pub fn read_block_file(block_file_path: &str) -> Block { | ||
| let encoded_block = std::fs::read(block_file_path) | ||
| .unwrap_or_else(|_| panic!("Failed to read block file with path {block_file_path}")); | ||
| Block::decode(&encoded_block) | ||
| .unwrap_or_else(|_| panic!("Failed to decode block file {block_file_path}")) | ||
| } | ||
|
Comment on lines
-68
to
-73
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I though the import command used this.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is done by |
||
|
|
||
| pub fn parse_sync_mode(s: &str) -> eyre::Result<SyncMode> { | ||
| match s { | ||
| "full" => Ok(SyncMode::Full), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri marked this conversation as resolved.
Show resolved
Hide resolved
ilitteri marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog shouldn't change. If anything, log that it was recently removed in a new entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_blacklisted'scase is particular since it was already dead when that change happened, but I see why we might not want to pretend it never happenedMaybe adding a note or a strikethrough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that changelog shouldn't be removed, but only appends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored previous version in 454e767