feat(l1): periodically fetch node records from peers. #5446
Conversation
* uses similar flow as lookup * store node records for future purposes
lakshya-sky
changed the title
lakshya-sky
changed the title
| } | ||
|
|
||
| /// Record a response received. Check previously saved hash and reset it if it matches | ||
| pub async fn record_enr_response_received( |
There was a problem hiding this comment.
I think this function is not used (and so, neither the RecordEnrResponseReceived message) because when we receive a ENRResponse we should record it directly (set_node_record), right?
There was a problem hiding this comment.
I've instead removed set_node_record and record_enr_response_received would set it directly after matching the hash.
| .try_into() | ||
| .expect("first 32 bytes are the message hash"); | ||
|
|
||
| if self.udp_socket.send_to(&buf, contact.node.udp_addr()) |
There was a problem hiding this comment.
Now it seems we have two kind of messages that save the hash. We may want to refactor it to have a single send_and_get_hash function (or some better naming 😬) to implement this logic only once.
It can be done on a different PR, though
ElFantasma
left a comment
ElFantasma
left a comment
There was a problem hiding this comment.
This looks good to me
Thanks Lakshya for your contribution!
|
|
||
| pub n_find_node_sent: u64, | ||
| /// ENR associated with this contact, if it was provided by the peer. | ||
| pub record: Option<NodeRecord>, |
There was a problem hiding this comment.
We should set this to None if we receive a PING with a different seq-num. I opened issue #5488 for that
3 participants
Motivation
Description
Towards #5423