Skip to content

fix(l1): avoid blocking during fullsync #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iovoid merged 2 commits into from
Nov 27, 2025
Merged

fix(l1): avoid blocking during fullsync #5445

iovoid merged 2 commits into from
Nov 27, 2025

Conversation

@iovoid
Copy link
Contributor

@iovoid iovoid commented Nov 27, 2025

Motivation

In fullsync, when in the final (head found) stage, we execute blocks individually. However, because we execute (sync) inside an async function, this blocks the runtime.

Description

Uses spawn_blocking to avoid blocking the runtime.

@iovoid iovoid requested a review from a team as a code owner November 27, 2025 18:11
@github-actions github-actions bot added the L1 Ethereum client label Nov 27, 2025
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025 •
edited
Loading

Lines of code report

Total lines added: 4
Total lines removed: 0
Total lines changed: 4

Detailed view 
+--------------------------------------+-------+------+
| File                                 | Lines | Diff |
+--------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync.rs | 1372  | +4   |
+--------------------------------------+-------+------+

MegaRedHand
MegaRedHand reviewed Nov 27, 2025
View reviewed changes
@iovoid iovoid enabled auto-merge November 27, 2025 18:19
@iovoid iovoid added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 0ef3272 Nov 27, 2025
43 checks passed
@iovoid iovoid deleted the avoid_blocking_fullsync branch November 27, 2025 18:54
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

@pablodeymo pablodeymo pablodeymo approved these changes

@fedacking fedacking fedacking approved these changes

Assignees

@iovoid iovoid

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iovoid @pablodeymo @fedacking @MegaRedHand