fix(l1): use correct block_num for base_fee in gas_tip_estimator #5444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
approved these changes
Nov 27, 2025
Oppen
approved these changes
Nov 27, 2025
Collaborator
|
@figtracer Commits must be signed. Please check our contributing docs more info: https://github.com/lambdaclass/ethrex/blob/main/CONTRIBUTING.md#commit-signature-verification |
Contributor
Author
On it |
figtracer
force-pushed
the
fix/gas_tip_estimator_base_fee
branch
3 times, most recently
from
0878d1d to
095b74e
Compare
figtracer
force-pushed
the
fix/gas_tip_estimator_base_fee
branch
from
095b74e to
ce9efc1
Compare
Contributor
Author
|
finally, for some reason i wasn't able to sign it 😁 @MegaRedHand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were using
latest_block_numberto samplebase_feeinstead of iterating throughblock_num. this PR fixes that problem.