feat(l1): preload previous 256 block hashes when creating vm database #5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
Benchmark Results ComparisonNo significant difference was registered for any benchmark run. Detailed ResultsBenchmark Results: BubbleSort
Benchmark Results: ERC20Approval
Benchmark Results: ERC20Mint
Benchmark Results: ERC20Transfer
Benchmark Results: Factorial
Benchmark Results: FactorialRecursive
Benchmark Results: Fibonacci
Benchmark Results: FibonacciRecursive
Benchmark Results: ManyHashes
Benchmark Results: MstoreBench
Benchmark Results: Push
Benchmark Results: SstoreBench_no_opt
|
Oppen
reviewed
Nov 28, 2025
| newest: BlockNumber, | ||
| oldest: BlockNumber, | ||
| ) -> Result<Vec<BlockHash>, StoreError> { | ||
| self.engine.get_canonical_block_hashes(newest, oldest) |
Contributor
There was a problem hiding this comment.
This should be reading from memory most of the time. Only on startup it should need to go to the DB to populate its in-memory cache.
Oppen
reviewed
Nov 28, 2025
Comment on lines
+1546
to
+1552
| let mut results = Vec::with_capacity(newest.saturating_sub(oldest) as usize); | ||
| for number in (oldest..newest).rev() { | ||
| match db.get_cf(&cf, number.to_le_bytes())? { | ||
| Some(res) => results.push(BlockHashRLP::from_bytes(res).to()?), | ||
| None => break, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This should fetch the whole range in batch:
Suggested change
| let mut results = Vec::with_capacity(newest.saturating_sub(oldest) as usize); | |
| for number in (oldest..newest).rev() { | |
| match db.get_cf(&cf, number.to_le_bytes())? { | |
| Some(res) => results.push(BlockHashRLP::from_bytes(res).to()?), | |
| None => break, | |
| } | |
| } | |
| let keys = (oldest..newest).map(BlockNumber::to_le_bytes()); | |
| let hashes = db.batched_multiget_cf(&cf, keys, true); | |
| hashes.into_iter().map(|h| h.ok().flatten().or_else(|| StoreError::Custom("missing value"))).collect() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addressing #5344 by using the existing
block_hash_cacheto preload the previous 256 block hashes so we can skip block hash lookup during executionAlternative to #5434 as proposed by review comment #5434 (comment)
Description
Benchmark Results: worse results than #5434 for BlockHash EEST gas benchmark:
1080.92 Mgas/s PR #5434
802.74 Mgas/s This PR
32.18 Gas/s Main (7b4a0ba)