fix(l2): fix ZisK install #5430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JereSalo
approved these changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes slow ZisK installation issues in GitHub Actions workflows by skipping the download of large proving key files from Google Cloud Storage. The proving keys are not needed for building and linting, only for actual proof generation.
- Adds
SETUP_KEY: noneenvironment variable to skip proving key download - Removes retry mechanism that was working around slow GCS downloads
- Simplifies workflow configuration by using direct
run:commands
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/tag_release.yaml |
Updated ZisK installation step to skip proving key download, removed retry mechanism and unnecessary environment variables |
.github/workflows/pr-main_l2_prover.yaml |
Applied same ZisK installation optimization to skip proving key download and remove retry mechanism |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpaulucci
approved these changes
Nov 26, 2025
github-merge-queue bot
pushed a commit
to lambdaclass/ethrex-replay
that referenced
this pull request
Nov 27, 2025
based on github.com/lambdaclass/ethrex/pull/5430 also pinned zisk version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes GitHub runners are slow to download from Google Cloud Storage, which is the case for the ZisK toolchain install. This downloads a proving key (big file) from GCS. This file is actually not necessary unless we want to generate a proof in a CI workflow.
Setting the
SETUP_KEYenv var should skip downloading this file.