Skip to content

fix(l2): replace ticker with sleep in dev-mode block producer #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilitteri merged 1 commit into from
Nov 26, 2025
Merged

fix(l2): replace ticker with sleep in dev-mode block producer #5429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions crates/blockchain/dev/block_producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ pub async fn start_block_producer(
) -> Result<(), EngineClientError> {
let engine_client = EngineClient::new(&execution_client_auth_url, jwt_secret);

let mut ticker = tokio::time::interval(Duration::from_millis(block_production_interval_ms));

// Sleep until the first tick to avoid timestamp collision with the genesis block.
ticker.tick().await;
// Sleep for one slot to avoid timestamp collision with the genesis block.
sleep(Duration::from_millis(block_production_interval_ms)).await;

let mut head_block_hash: H256 = head_block_hash;
let parent_beacon_block_root = H256::zero();
Expand Down Expand Up @@ -61,9 +59,9 @@ pub async fn start_block_producer(
.payload_id
.expect("Failed to produce block: payload_id is None in ForkChoiceResponse");

// Wait for the next tick to retrieve the payload.
// Wait to retrieve the payload.
// Note that this makes getPayload failures result in skipped blocks.
ticker.tick().await;
sleep(Duration::from_millis(block_production_interval_ms)).await;

let execution_payload_response = match engine_client.engine_get_payload_v5(payload_id).await
{
Expand Down